Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override
Albert Astals Cid
aacid at kde.org
Sat Oct 18 07:20:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120641/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: attica
Description
-------
Turn virtuals that are not virtuals into Q_DECL_OVERRIDE
Also rename setNameAccessManager into setNam so that it actually overrides the base. I've serached in lxr.kde.org and there's no calls to any of the two so we're fine.
Diffs
-----
src/deletejob.h 90a4578
src/getjob.h 2ec9d76
src/itemjob.h 8a373c3
src/listjob.h 05f351e
src/postjob.h 90bb8f4
src/putjob.h 6267a78
src/qtplatformdependent.cpp efd49aa
src/qtplatformdependent_p.h 4be2f2e
Diff: https://git.reviewboard.kde.org/r/120641/diff/
Testing
-------
Compiles
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141018/9c7b43d6/attachment.html>
More information about the Kde-frameworks-devel
mailing list