Review Request 120622: Update QIconItem on resize

Aleix Pol Gonzalez aleixpol at kde.org
Fri Oct 17 14:41:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120622/#review68614
-----------------------------------------------------------

Ship it!


Looks good!

- Aleix Pol Gonzalez


On Oct. 17, 2014, 2:41 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120622/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 2:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Update QIconItem on resize. 
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp bd8c9ec 
>   tests/qiconitem_resize.qml PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 1970fda 
> 
> Diff: https://git.reviewboard.kde.org/r/120622/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> Previously clicking the button visibly did nothing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141017/de191a43/attachment.html>


More information about the Kde-frameworks-devel mailing list