Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120598/#review68518
-----------------------------------------------------------


Well spotted, porting bug:

(commit 3fde4d63887ecbb57ac92f61cc36ff5240ce86f3)

-            mode = (RenameDialog_Mode)(mode | M_MULTI | M_SKIP);
+            options = RenameDialog_Options(RenameDialog_MultipleItems | RenameDialog_Skip);

the "mode |" was lost.

So let's fix this properly: it should be   options |
rather than hardcoding Overwrite, which is already determined in the code above. Can you check that
options = RenameDialog_Options(options | RenameDialog_MultipleItems | RenameDialog_Skip);
fixes your bug? Thanks.

- David Faure


On Oct. 15, 2014, 1:05 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120598/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 1:05 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When copying multiple files there are only options to rename and skip already existing files, but in KDE 4 I was used to also overwrite them. This patch just simply adds this option to RenameDialog in Kio::CopyJob. 
> 
> 
> Diffs
> -----
> 
>   src/core/copyjob.cpp 9f1826a 
> 
> Diff: https://git.reviewboard.kde.org/r/120598/diff/
> 
> 
> Testing
> -------
> 
> I tested it in Dolphin and it seems to work.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141015/bbcec7a6/attachment.html>