Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120599/#review68517
-----------------------------------------------------------

Ship it!


Correct, thanks. But please also remove the redundant if() then.


src/filewidgets/knewfilemenu.cpp
<https://git.reviewboard.kde.org/r/120599/#comment47717>

    You're right. I reviewed the code, and src is always a local path. For this reason, this if() should be removed. It makes no sense to test isLocalFile() just after fromLocalFile() :-)


- David Faure


On Oct. 15, 2014, 1:05 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120599/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 1:05 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> In KNewFileMenu when trying to copy a temporary file as a new file or editing a desktop file it doesn't contruct the URL properly and it fails to create it and returns a KIO error.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/knewfilemenu.cpp a24ac9c 
> 
> Diff: https://git.reviewboard.kde.org/r/120599/diff/
> 
> 
> Testing
> -------
> 
> Tested in dolphin and now I'm able to create a new text file or link to an application.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141015/58cc96be/attachment-0001.html>