Review Request 120592: enable autotests for knewstuff

Aleix Pol Gonzalez aleixpol at kde.org
Tue Oct 14 23:40:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/#review68423
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 14, 2014, 11:19 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120592/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 11:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Enable autotests.
> 
> Make autotests build in the sources they need to test to avoid exporting.
> Patch by Albert Astals Cid <aacid at kde.org>
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt c210f70c493fc7febb9157f212e23c92042315c7 
>   autotests/knewstuffentrytest.cpp fbf2e0d7478def609a2cb9912139a6bbc20197fc 
> 
> Diff: https://git.reviewboard.kde.org/r/120592/diff/
> 
> 
> Testing
> -------
> 
> The tests build and pass here.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141014/a9aacb88/attachment.html>


More information about the Kde-frameworks-devel mailing list