Review Request 120574: Add explicit to ctors with one parameter

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120574/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 10:11 a.m.)


Review request for KDE Frameworks, David Faure, Vavelin Kevin, and Jeremy Whiting.


Changes
-------

Added Kevin and David to weigh in.


Repository: knewstuff


Description
-------

Add explicit to ctors with one parameter


Diffs
-----

  src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 
  src/button.h 155b6dc5f4b032970bcd0e5400cf5dba12f76e81 
  src/core/engine_p.h f7a6884d9a22c56f1feff8b6c97fa242f46533da 
  src/core/installation_p.h 9d855a26590dcee2259fe657fc7c3293669e3f81 
  src/core/xmlloader_p.h 7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29 
  src/downloadwidget_p.h 37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36 
  src/ui/itemsview_p.h df65d0b47abaddd404a171890e47af1b93c4203f 
  src/ui/progressindicator_p.h 3d18bff8eac6b8a21f94da39b21b51ee334ec3de 

Diff: https://git.reviewboard.kde.org/r/120574/diff/


Testing
-------

It builds and khotnewstuff test app still works.

My only question is if this source incompatible change is allowed in frameworks or not.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141014/085b3c0e/attachment.html>