Review Request 120581: Don't crash if the plasmoid wasn't properly loaded
Marco Martin
notmart at gmail.com
Tue Oct 14 13:11:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120581/#review68390
-----------------------------------------------------------
Ship it!
Inviala!
- Marco Martin
On Ott. 14, 2014, 1:09 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120581/
> -----------------------------------------------------------
>
> (Updated Ott. 14, 2014, 1:09 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null.
>
> This makes Plasma crash when a plasmoid is loaded.
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.cpp 45055a5
>
> Diff: https://git.reviewboard.kde.org/r/120581/diff/
>
>
> Testing
> -------
>
> Doesn't crash anymore.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141014/a1ba7529/attachment.html>
More information about the Kde-frameworks-devel
mailing list