Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120550/#review68302
-----------------------------------------------------------



src/quickaddons/imagetexturescache.h
<https://git.reviewboard.kde.org/r/120550/#comment47603>

    would like some apidocs: at the beginning of the class some doc on why and how use this class, and just a bit of apidoc on loadTexture()


- Marco Martin


On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120550/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 11:13 a.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Moves the caching types used in Plasma Workspace into a QuickAddons submodule.
> 
> Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 
>   src/quickaddons/CMakeLists.txt PRE-CREATION 
>   src/quickaddons/imagetexturescache.h PRE-CREATION 
>   src/quickaddons/imagetexturescache.cpp PRE-CREATION 
>   src/quickaddons/managedtexturenode.h PRE-CREATION 
>   src/quickaddons/managedtexturenode.cpp PRE-CREATION 
>   tests/qiconitem_test.qml PRE-CREATION 
>   src/CMakeLists.txt eb0dfd3 
> 
> Diff: https://git.reviewboard.kde.org/r/120550/diff/
> 
> 
> Testing
> -------
> 
> I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141013/926b5f93/attachment.html>