Review Request 120075: KArchive: add support for rcc files

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120075/#review68263
-----------------------------------------------------------

Ship it!


some small nitpicks from my side :)


src/krcc.h
<https://git.reviewboard.kde.org/r/120075/#comment47565>

    "ar" file? maybe "archive" instead?



src/krcc.h
<https://git.reviewboard.kde.org/r/120075/#comment47566>

    here and below: "Writing *is* not supported by this class, *it* will always fail."



src/krcc.h
<https://git.reviewboard.kde.org/r/120075/#comment47568>

    scoped pointer?



src/krcc.cpp
<https://git.reviewboard.kde.org/r/120075/#comment47567>

    here and below: the { should go to its own line, no?



src/krcc.cpp
<https://git.reviewboard.kde.org/r/120075/#comment47569>

    maybe I'm missing something, but this looks like you don't need to override it at all when you just delegate to the base class anyways?



tests/krcctest.cpp
<https://git.reviewboard.kde.org/r/120075/#comment47570>

    I knew it, you are a time traveler! :P


- Milian Wolff


On Oct. 10, 2014, 8:46 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120075/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 8:46 p.m.)
> 
> 
> Review request for KDE Frameworks, Mario Bensi and Kevin Krammer.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> These the dynamic binary resources created by Qt's rcc tool from a .qrc file
> and the files it points to.
> 
> [ChangeLog] KArchive: add support for rcc files
> 
> 
> The idea came up while talking to the GCompris author, who mentionned he's using .rcc files quite a lot in his application and was missing a way to look into such a file to find out what it contains. Now with very little work, ark could support these too. It just needs to be ported to KF5 first :-)
> 
> 
> Diffs
> -----
> 
>   autotests/karchivetest.h 567be075758f6afd4bdff5a2f6f8ef5e392a53eb 
>   autotests/karchivetest.cpp 6b50f32a6d99756ba246262067dd71573f129256 
>   autotests/runtime_resource.rcc PRE-CREATION 
>   src/CMakeLists.txt 948a25b5e017a11c1577c7c324f2fa3545b13f52 
>   src/krcc.h PRE-CREATION 
>   src/krcc.cpp PRE-CREATION 
>   tests/CMakeLists.txt ebcd01f5bfdec1298bbc936b9429b187f50c9b45 
>   tests/krcctest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120075/diff/
> 
> 
> Testing
> -------
> 
> Manual test prog, autotest.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141011/48d2eb9f/attachment.html>