Review Request 120382: Port comicbook thumbnailer to KF5

[David Faure]

> On Sept. 26, 2014, 10:44 p.m., David Edmundson wrote:
> > thumbnail/comiccreator.cpp, line 227
> > <https://git.reviewboard.kde.org/r/120382/diff/1/?file=315507#file315507line227>
> >
> >     Why do we run unrar manually when we're already linking against karchive elsewhere?
> >     
> >     (I understand this is existing code, I'm just wondering if you know)
> 
> Maarten De Meyer wrote:
>     Yes I noticed that too. I already placed it on my mental todo list of things that can be improved :)
>     Thanks!

Because KArchive doesn't support RAR at the moment.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120382/#review67504
-----------------------------------------------------------


On Sept. 28, 2014, 3:46 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120382/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 3:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Mostly standard porting stuff.
> I'll change the qdebug calls to qCDebug later. I'm planning to create a global thumbnail logging component.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b582741 
>   thumbnail/CMakeLists.txt cd1263a 
>   thumbnail/comiccreator.cpp 39df58a 
> 
> Diff: https://git.reviewboard.kde.org/r/120382/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my small collection (only cbr files)
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141010/a9f6a33a/attachment.html>