Review Request 120551: Enable test mode when starting kded5 from a unittest.

Hrvoje Senjan hrvoje.senjan at gmail.com
Fri Oct 10 20:12:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120551/#review68227
-----------------------------------------------------------

Ship it!


Ship It!

- Hrvoje Senjan


On Oct. 10, 2014, 9:58 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120551/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 9:58 p.m.)
> 
> 
> Review request for KDE Frameworks, Hrvoje Senjan and Lukáš Tinkl.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> But not when it's already set, that's rather pointless.
> 
> Fixes up RR 120519, which moved the call to the "kded already running and has test mode enabled" code path.
> 
> 
> Diffs
> -----
> 
>   src/sycoca/ksycoca.cpp 9434c8067d725421ec93141d44019d5e75ef9547 
> 
> Diff: https://git.reviewboard.kde.org/r/120551/diff/
> 
> 
> Testing
> -------
> 
> kservice and kio tests still pass, although I didn't make sure they exercised this code path.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141010/fb9d7945/attachment.html>


More information about the Kde-frameworks-devel mailing list