Review Request 120535: attica: Add const to getter methods.
Albert Astals Cid
aacid at kde.org
Wed Oct 8 21:22:58 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120535/#review68095
-----------------------------------------------------------
According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ "changing the const/volatile qualifiers of the function" is BIC
Now the thing is if we allow BIC changes in frameworks like attica or not is for someone else to answer.
- Albert Astals Cid
On oct. 8, 2014, 9:20 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120535/
> -----------------------------------------------------------
>
> (Updated oct. 8, 2014, 9:20 p.m.)
>
>
> Review request for KDE Frameworks, kdelibs and Frederik Gladhorn.
>
>
> Repository: attica
>
>
> Description
> -------
>
> Add const to getter methods.
>
>
> Diffs
> -----
>
> src/downloaddescription.h 08796c9283d1412386f6e096b981c3afa2b1f55e
> src/downloaddescription.cpp f76a1601a53e66b836623f4ac7a67ceeb543c1f0
>
> Diff: https://git.reviewboard.kde.org/r/120535/diff/
>
>
> Testing
> -------
>
> This builds and an improved knewstuff (with const AtticaDescription &foo, bar) in foreach lines builds.
>
> My only question about committing this is if it's allowed since it's a binary incompatible change. If it's not allowed I will add duplicates of these methods that are const and deprecate these non-const ones instead.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141008/dce44d35/attachment.html>
More information about the Kde-frameworks-devel
mailing list