Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false
Lukáš Tinkl
lukas at kde.org
Wed Oct 8 20:09:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120519/#review68091
-----------------------------------------------------------
Ship it!
Seems sensible to me
- Lukáš Tinkl
On Říj. 7, 2014, 2:22 odp., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120519/
> -----------------------------------------------------------
>
> (Updated Říj. 7, 2014, 2:22 odp.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> Noticed that during startup something creates ~/.qttest directory, after a bit of investigation, found that are those 2 misplaced lines...
>
>
> Diffs
> -----
>
> src/sycoca/ksycoca.cpp a2c8c2f
>
> Diff: https://git.reviewboard.kde.org/r/120519/diff/
>
>
> Testing
> -------
>
> on empty user/config, ~/.qttest no longer created/used
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141008/f87ab994/attachment.html>
More information about the Kde-frameworks-devel
mailing list