Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted
Valentin Rusu
kde at rusu.info
Tue Oct 7 19:12:36 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120387/#review68063
-----------------------------------------------------------
Ship it!
Ship It!
- Valentin Rusu
On Sept. 27, 2014, 11:44 a.m., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120387/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2014, 11:44 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> If `walletListDirty()` is not emitted, kwalletmanager would continue to show the wallets even though it doesnt exist on the disk. These would be removed from the list only when the wallet is closed. If the user had added any new data to the wallets, it would be lost
>
>
> Diffs
> -----
>
> src/runtime/kwalletd/kwalletd.cpp 4eb8381
>
> Diff: https://git.reviewboard.kde.org/r/120387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141007/4efb6194/attachment.html>
More information about the Kde-frameworks-devel
mailing list