Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false
Martin Klapetek
martin.klapetek at gmail.com
Tue Oct 7 11:34:50 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120519/#review68047
-----------------------------------------------------------
Looks good, I'd like someone giving it a second look though
src/sycoca/ksycoca.cpp
<https://git.reviewboard.kde.org/r/120519/#comment47427>
The indentation seems off
- Martin Klapetek
On Oct. 7, 2014, 12:38 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120519/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 12:38 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> Noticed that during startup something creates ~/.qttest directory, after a bit of investigation, found that are those 2 misplaced lines...
>
>
> Diffs
> -----
>
> src/sycoca/ksycoca.cpp a2c8c2f
>
> Diff: https://git.reviewboard.kde.org/r/120519/diff/
>
>
> Testing
> -------
>
> on empty user/config, ~/.qttest no longer created/used
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141007/41759c9d/attachment.html>
More information about the Kde-frameworks-devel
mailing list