Review Request 120099: RFC: UI-Files inside resources instead of filesystem

Christoph Cullmann cullmann at kde.org
Sun Oct 5 17:32:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120099/
-----------------------------------------------------------

(Updated Oct. 5, 2014, 5:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kxmlgui


Description
-------

Instead of installing them in the kxmlgui5 share prefix, install them in a kxmlgui5 prefix in resources.
That will allow to test stuff without installing it first, as the resources will be found anyway.
Still the "I can edit it and have a copy in my writable datadir" should work.
Question is: is it possible with one "kxmlgui" prefix for the resource or is it better to swap that around like "componentname/kxmlgui5/.."?


Diffs
-----

  src/kxmlguiclient.cpp e8170ad 
  src/kxmlguifactory.cpp c4ad97b 

Diff: https://git.reviewboard.kde.org/r/120099/diff/


Testing
-------

Compiles & if I package ui file in kate into resource, works.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141005/5be1c868/attachment.html>


More information about the Kde-frameworks-devel mailing list