Review Request 120458: Port html, djvu and folder thumbcreators

[Maarten De Meyer]

> On Oct. 4, 2014, 8:57 a.m., David Faure wrote:
> > thumbnail/thumbnail.cpp, line 491
> > <https://git.reviewboard.kde.org/r/120458/diff/2/?file=316048#file316048line491>
> >
> >     the method name in this comment needs to be updated too, but before that, I'd advise re-testing without this line. It should work, with QMimeType, AFAICS.

You are right, good catch!
There is still a regression here. Custom icons for folders are ignored. Do I add support for that in KIO::iconNameForUrl or only here?

Thanks.


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120458/#review67885
-----------------------------------------------------------


On Oct. 4, 2014, 5:31 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120458/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2014, 5:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 339456
>     https://bugs.kde.org/show_bug.cgi?id=339456
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> We need QApplication for KWebPage.
> Store thumbnails created by directory thumbnailer with the correct name.
> I also enabled the desktop thumbnailer, it uses textcreator.
> 
> note: I still need to port thumbnail.cpp away from KDE4support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2036392 
>   thumbnail/CMakeLists.txt 4c2d5e9 
>   thumbnail/djvucreator.cpp 1035b98 
>   thumbnail/htmlcreator.cpp ea553f0 
>   thumbnail/thumbnail.cpp d4a7f35 
> 
> Diff: https://git.reviewboard.kde.org/r/120458/diff/
> 
> 
> Testing
> -------
> 
> Thumbnails work.
> djvu and html only tested with a single file each. It would be great if somebody with a big collection of these files could check for regressions.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141004/1e9e7008/attachment.html>