Review Request 120185: Look for kdesu in the correct location

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185/#review67887
-----------------------------------------------------------


libexec/kf5 is necessary for it to be co-installable with KDE SC 4, no?

- David Faure


On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120185/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 3:59 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 338755
>     https://bugs.kde.org/show_bug.cgi?id=338755
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup.
> Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5?
> 
> Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is "Could not launch 'root'" which is somewhat correct but not as easy to figure out as "Could not launch 'kdesu'"
> 
> Also added an unrelated QFile::decodeName() call.
> 
> 
> Diffs
> -----
> 
>   src/core/config-kiocore.h.cmake 3c2e4a8 
>   src/core/desktopexecparser.cpp 9510697 
> 
> Diff: https://git.reviewboard.kde.org/r/120185/diff/
> 
> 
> Testing
> -------
> 
> Created .desktop file with X-KDE-SubstituteUID=true
> Now I can launch it as root and when I remove kdesu I got a normal error message.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141004/0db77830/attachment.html>