Review Request 120267: Don't run kioexec if we are already running it

[Maarten De Meyer]

> On Oct. 3, 2014, 11:32 a.m., Elias Probst wrote:
> > This patch fixes the issue for me, but I can't really say much about the quality of the patch -- needs someone with some more domain-specific knowledge to give you a "ship it".

No problem. I think dfaure is on vacation. Or busy :)
Anyway this I still have to update the unit test for this.
Thanks for taking a look.


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/#review67855
-----------------------------------------------------------


On Sept. 18, 2014, 4:33 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120267/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 339123
>     https://bugs.kde.org/show_bug.cgi?id=339123
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Only add the actual command and url's otherwise we keep spawning instances of kioexec.
> Maybe we should rename the kioexec service from 'dummy' to 'kioexec-dummy' just to be safe.
> 
> 
> Diffs
> -----
> 
>   src/core/desktopexecparser.cpp 9510697 
> 
> Diff: https://git.reviewboard.kde.org/r/120267/diff/
> 
> 
> Testing
> -------
> 
> Run kioexec with local file from command line.
> Remote files don't work (before and after) I'll take a look at that next.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141003/7fb21c59/attachment.html>