Review Request 120480: decide at build time where the home of KDE4 is

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/#review67864
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 3, 2014, 3:34 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120480/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply checking ~/.kde then ~/.kde4.
> but in Plasma5 we need to be really sure where ~/.kde is since some settings are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to create it from kf5, that's why the kdehome() method)
> also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 configs in user homes is very possible)
> 
> this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with _KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of distributions to make this right.
> on the other hand if the user changes distribution at the moment of the migration between kde4 and plasma5 this may break.
> 
> 
> Diffs
> -----
> 
>   src/lib/util/config-kde4home.h.cmake PRE-CREATION 
>   src/lib/util/kdelibs4migration.cpp e1ec678 
>   src/lib/CMakeLists.txt 5ae5c08 
> 
> Diff: https://git.reviewboard.kde.org/r/120480/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141003/957b3583/attachment.html>