Review Request 120435: Declare InheritanceChecker before actual use
David Edmundson
david at davidedmundson.co.uk
Fri Oct 3 10:43:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120435/#review67853
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Sept. 30, 2014, 11:36 a.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120435/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 11:36 a.m.)
>
>
> Review request for KDE Frameworks and Ben Cooksley.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Declare InheritanceChecker before actual use
>
> This is actually not needed for "proper" compilers, because the use is inside a template,
> The type is only required at instantiation time.
>
> However, this patch makes the Coverity build tool happy. Without this patch,
> we get an error for every translation unit including
> kpluginfactory.h, telling us that "InheritanceChecker is not a
> template"
>
> Also see https://communities.coverity.com/thread/2903
>
>
> Diffs
> -----
>
> src/lib/plugin/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178
>
> Diff: https://git.reviewboard.kde.org/r/120435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141003/c67181ff/attachment.html>
More information about the Kde-frameworks-devel
mailing list