Review Request 120467: Native Qt Quick FileDialog

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120467/
-----------------------------------------------------------

Review request for KDE Frameworks and Frederik Gladhorn.


Bugs: 334963
    https://bugs.kde.org/show_bug.cgi?id=334963


Repository: frameworkintegration


Description
-------

I'm trying to fix bug [334963](https://bugs.kde.org/show_bug.cgi?id=334963) but I need some help to solve this one.

commit 2ee76f0fa234d5db3e1dd6650fe82debaa38a1ce by Frederik Gladhorn removes the exec() from ::show() and mentions that m_dialog->exec() is called twice. But running the example from the bug report (and Qt documentation) never seems to call ::exec()

If I re-add an exec call the FileDialog is shown. But I doubt it is that simple.
Also cancel is not emitted, the dialog closes but the application doesn't quit.

Help appreciated :)


Diffs
-----

  src/platformtheme/kdeplatformfiledialoghelper.cpp 0a4f89f 

Diff: https://git.reviewboard.kde.org/r/120467/diff/


Testing
-------

Dialog visible.
Select file: returns name and quits
Cancel: closes dialog but doesn't quit!


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141002/13e3ae1e/attachment.html>