Review Request 120449: Avoid infinite recursion in KSNI

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120449/
-----------------------------------------------------------

(Updated Oct. 1, 2014, 4:43 p.m.)


Review request for KDE Frameworks.


Repository: knotifications


Description
-------

KStatusNotifierItem falls back to making a QSystemTray. With the KDE Qt
plugin our QSystemTrays create a StatusNotifierItem at which point we
are in infinite recursion.

This happens on bootup if we try to create a SNI before plasma is loaded but the KDE platform theme is being loaded. (for example the keyboard layout SNI which is in a KDED and loaded first)

Alternate approach to my preferred https://git.reviewboard.kde.org/r/120243/ which simply removes the legacy support.


**NOTE WE NEED A FIX IN THIS RELEASE OTHERWISE ALL PLASMA SESSIONS WILL COMPLETELY BREAK AS SOON AS Qt 5.4 COMES OUT.**

--

patch isn't thread safe, but realistically no-one will be making multiple KSI's in multiple threads


Diffs (updated)
-----

  src/kstatusnotifieritem.cpp 767537d 

Diff: https://git.reviewboard.kde.org/r/120449/diff/


Testing
-------

Logged in successfully.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141001/e77fa77b/attachment.html>