Review Request 120448: Fix initial size of KCMultiDialog

Christoph Feck christoph at maxiom.de
Wed Oct 1 14:50:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120448/#review67764
-----------------------------------------------------------

Ship it!



src/kcmultidialog.h
<https://git.reviewboard.kde.org/r/120448/#comment47195>

    Space between type and *



src/kcmultidialog.cpp
<https://git.reviewboard.kde.org/r/120448/#comment47196>

    type* v -> type *v


- Christoph Feck


On Oct. 1, 2014, 1:24 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120448/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 1:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 325897 and 337494
>     https://bugs.kde.org/show_bug.cgi?id=325897
>     https://bugs.kde.org/show_bug.cgi?id=337494
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> The size was adjusted before having the pages added, so it didn't have a chance to figure out the correct size properly.
> 
> 
> Diffs
> -----
> 
>   src/kcmultidialog.h 78b1625 
>   src/kcmultidialog.cpp 8fd2cfd 
> 
> Diff: https://git.reviewboard.kde.org/r/120448/diff/
> 
> 
> Testing
> -------
> 
> Reproduced the Bugs in the "Bugs:" section (Baloo and KDE Connect).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141001/b9cd8811/attachment.html>


More information about the Kde-frameworks-devel mailing list