Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

Alexander Richardson arichardson.kde at gmail.com
Sun Nov 30 14:11:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121283/
-----------------------------------------------------------

(Updated Nov. 30, 2014, 2:11 p.m.)


Review request for KDE Frameworks, David Faure and Nicolás Alvarez.


Changes
-------

I keep forgetting what we are allowed to use, C++11 wise, in frameworks. Nicolas, is nullptr allowed on MSVC? What about the STL functionality used here, is that OK?


Repository: kxmlgui


Description (updated)
-------

Allow using new style connect in KActionCollection::add[Action]()


Diffs
-----

  src/kactioncollection.h 879f59201111bddc04c9ff48d137ae386a860382 

Diff: https://git.reviewboard.kde.org/r/121283/diff/


Testing
-------


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141130/d987d3eb/attachment.html>


More information about the Kde-frameworks-devel mailing list