Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

Alexander Richardson arichardson.kde at gmail.com
Fri Nov 28 20:02:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/
-----------------------------------------------------------

(Updated Nov. 28, 2014, 8:02 nachm.)


Review request for KDE Frameworks.


Changes
-------

remove unneccesary code, this is handled below


Repository: kconfigwidgets


Description
-------

Not sure if MSVC has the necessary type_traits working, but can't test that now since it don't have a Windows machine available.


Diffs (updated)
-----

  autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
  src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 
  autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
  src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 

Diff: https://git.reviewboard.kde.org/r/121218/diff/


Testing
-------

The newly added unit test passes


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141128/9ddb859a/attachment.html>


More information about the Kde-frameworks-devel mailing list