kdirlister test is too coupled

[Albert Astals Cid]

El Diumenge, 23 de novembre de 2014, a les 22:37:33, David Faure va escriure:
> On Sunday 23 November 2014 22:17:27 Albert Astals Cid wrote:
> > kdirlister test is highly dependant on run order, seems it needs
> > testOpenUrl to always have run otherwise it always fails
> > 
> > i.e.
> > 
> >   ./autotests/kdirlistertest testRefreshRootItem
> 
> Yes, just do
> ./autotests/kdirlistertest testOpenUrl testRefreshRootItem
> 
> This is known, the comment in the first line of testRefreshRootItem implies
> that.
> 
> > I tried doing a quick refactor of renaming testOpenUrl to init() but then
> > some other stuff failed.
> > 
> > Can someone with more knowledge of kdirlister and the test have a look?
> 
> Not really critical if your problem is solved by adding one word on the
> command-line, right?

The problem is that knowing you have to add testOpenUrl in front of 
testRefreshRootItem hard to gain knowledge ;)

But sure it's not critical.

It's more of a problem that the test seems to be unstable in jenkins (can't 
reproduce locally)

Cheers,
  Albert