Review Request 121210: Provide an accessible name for KLed

[José Millán Soto]

> On Nov. 22, 2014, 6:31 p.m., Christoph Feck wrote:
> > I think the updateAccessibleName() should also be called from the constructors? Otherwise, the initial name (for which even a constructor exists), is never announced.

In the new version of the patch, it's called in the constructors. In the old one it was not called there as the constructors called setColor, which called updateCachedPixmap, which called updateAccessibleName.


- José


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121210/#review70793
-----------------------------------------------------------


On Nov. 23, 2014, 4:09 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121210/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 4:09 p.m.)
> 
> 
> Review request for KDE Accessibility, KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This patch will provide a default accessible name for KLed. That name will only say that the widget is a led and the status of the led. If another accessible name has been assigned, it will not be overwritten.
> The accessible name will allow accessible tools (such as screen readers) to provide some infomation about the widget.
> 
> 
> Diffs
> -----
> 
>   src/kled.cpp 9788fc2 
>   src/kled.h eeb1209 
> 
> Diff: https://git.reviewboard.kde.org/r/121210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141123/577fcf6a/attachment.html>