Review Request 121210: Provide an accessible name for KLed

[Christoph Feck]

> On Nov. 22, 2014, 4:40 p.m., David Gil Oliva wrote:
> > src/kled.h, line 257
> > <https://git.reviewboard.kde.org/r/121210/diff/1/?file=329497#file329497line257>
> >
> >     It should be hidden behind the d-pointer.
> 
> José Millán Soto wrote:
>     Why should it be hidden?
>     As it is not a virtual function it should not cause binary incompatibility.
> 
> David Gil Oliva wrote:
>     I tend to think That everything private should be behind the d-pointer. It keeps a tighter encapsulation. But maybe I'm wrong...

Generally, I agree, but the Private class currently has no q-pointer back to the widget, and I do not think it is worth adding it just for this single function.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121210/#review70783
-----------------------------------------------------------


On Nov. 22, 2014, 4:32 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121210/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 4:32 p.m.)
> 
> 
> Review request for KDE Accessibility and KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This patch will provide a default accessible name for KLed. That name will only say that the widget is a led and the status of the led. If another accessible name has been assigned, it will not be overwritten.
> The accessible name will allow accessible tools (such as screen readers) to provide some infomation about the widget.
> 
> 
> Diffs
> -----
> 
>   src/kled.h eeb1209 
>   src/kled.cpp 9788fc2 
> 
> Diff: https://git.reviewboard.kde.org/r/121210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141122/e2ab5df6/attachment.html>