Review Request 121153: Restore filedialog show() functionality for modal dialogs

[Albert Astals Cid]

> On nov. 17, 2014, 11:33 p.m., Jeremy Whiting wrote:
> > I tested this here and FileDialog qml still hangs the ui with this patch. (though at least the dialog appears)
> 
> Martin Klapetek wrote:
>     Yes, QML still hangs, not sure why though. Looking into it.
> 
> Martin Klapetek wrote:
>     So I've spent a considerable amount of time on this but to no avail. I've even rewritten significant portion of our file dialog to match the gtk2 platform theme plugin one, but it still wouldn't work.
>     
>     I'm at a loss here, sorry...

Then maybe use https://git.reviewboard.kde.org/r/121098/diff/# since Jeremy says qml dialogs work there?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121153/#review70564
-----------------------------------------------------------


On nov. 17, 2014, 5:46 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121153/
> -----------------------------------------------------------
> 
> (Updated nov. 17, 2014, 5:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Based on https://git.reviewboard.kde.org/r/121098/ and on the GTK2 platform theme, which does the modal show() like this.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca19 
> 
> Diff: https://git.reviewboard.kde.org/r/121153/diff/
> 
> 
> Testing
> -------
> 
> All kinds of file dialogs from tests/qfiledialogtest work as expected
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141120/1c2a9901/attachment.html>