Review Request 121178: Fix build of kdelibs4support on OSX/CI

Marko Käning mk-lists at email.de
Wed Nov 19 19:32:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121178/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdelibs4support


Description
-------

This was a new bug introduced by kcodecs' commit ca74c40ab79cb8d5fbffc4418c83a53071040218
```
[ 92%] [ 93%] Building CXX object.o
Undefined symbols for architecture x86_64:
  "KCodecs::base64Encode(QByteArray const&)", referenced from:
      testCodec(char const*, Codec, bool) in kmdcodectest.cpp.o
ld: symbol(s) not found for architecture x86_64
Built target kfiletreeviewtest
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [tests/kmdcodectest.app/Contents/MacOS/kmdcodectest] Error 1
make[1]: *** [tests/CMakeFiles/kmdcodectest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
```
and can be fixed by adding the boolean parameter explicitely.


Diffs
-----

  tests/kmdcodectest.cpp fb0902f 

Diff: https://git.reviewboard.kde.org/r/121178/diff/


Testing
-------

Builds fine on OSX/CI


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141119/27388c8b/attachment.html>


More information about the Kde-frameworks-devel mailing list