Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

[Michael Hansen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120760/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 6:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
-------

Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces.

This also now uses the indentation width rather than the tab width, as I see "Tab Width" as being the actual width of the \t character, and "Indentation width" as being the next alignment position for virtual indentation.  This more closely matches other editors (e.g. vim) which have similar indentation control.


Diffs
-----

  src/document/katedocument.h 8e93f7a9940c98324236f1269d25ccf98d04f968 
  src/document/katedocument.cpp 9a809fad5fe879f11402cf9d274b3463cb267d66 

Diff: https://git.reviewboard.kde.org/r/120760/diff/


Testing
-------

Typed the testcase in bug 340212 with various indent/tab width settings.  Only Soft Tab mode is affected by this change.

With Indent 4/Tab 4:
    int     x;
    string  y;
    bool    z;

With Indent 4/Tab 8:
    int     x;
    string  y;
    bool    z;

With Indent 8/Tab 8 (single [tab] on the first line):
        int     x;
        string  y;
        bool    z;


Thanks,

Michael Hansen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141118/c16588a9/attachment.html>