Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

Sebastian Kügler sebas at kde.org
Tue Nov 18 11:55:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121084/#review70581
-----------------------------------------------------------

Ship it!


Looks sane to me, also solves a real-world problem. Thanks!

- Sebastian Kügler


On Nov. 9, 2014, 4:10 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121084/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Runtime, KDE Frameworks and Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> KDE-Runtime already provides libmolletnetwork, so lets rename
> this one to include 5 as a suffix since many apps outside of
> KDE still depend on KDE-Runtime.
> 
> 
> Diffs
> -----
> 
>   network/ioslave/CMakeLists.txt 06a964d 
>   network/kded/CMakeLists.txt 3be676e 
>   network/network/CMakeLists.txt c0fb43e 
> 
> Diff: https://git.reviewboard.kde.org/r/121084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141118/3124310a/attachment.html>


More information about the Kde-frameworks-devel mailing list