Review Request 121153: Restore filedialog show() functionality for modal dialogs

[Martin Klapetek]

> On Nov. 18, 2014, 12:33 a.m., Jeremy Whiting wrote:
> > I tested this here and FileDialog qml still hangs the ui with this patch. (though at least the dialog appears)

Yes, QML still hangs, not sure why though. Looking into it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121153/#review70564
-----------------------------------------------------------


On Nov. 17, 2014, 6:46 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121153/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Based on https://git.reviewboard.kde.org/r/121098/ and on the GTK2 platform theme, which does the modal show() like this.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca19 
> 
> Diff: https://git.reviewboard.kde.org/r/121153/diff/
> 
> 
> Testing
> -------
> 
> All kinds of file dialogs from tests/qfiledialogtest work as expected
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141118/1d11cec2/attachment.html>