Review Request 121098: Restore filedialog functionality for modal dialogs.

Jeremy Whiting jpwhiting at kde.org
Mon Nov 17 16:39:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121098/
-----------------------------------------------------------

(Updated Nov. 17, 2014, 9:39 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Eike Hein.


Repository: frameworkintegration


Description
-------

Before David's astyle commit, the show method used to call m_dialog->exec
if the window flags weren't nonmodal (i.e. modal dialogs). This got removed somehow.
BUG:334963


Diffs
-----

  src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca192946f0da2b357b33e93a57ef0de05135b 

Diff: https://git.reviewboard.kde.org/r/121098/diff/


Testing
-------

fifteen puzzle config with patch from https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you choose a file.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141117/cf6afddf/attachment.html>


More information about the Kde-frameworks-devel mailing list