Review Request 121143: add translationDomain for katepartui.rc

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121143/#review70477
-----------------------------------------------------------

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On Nov. 16, 2014, 8:27 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121143/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2014, 8:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Translation messages in src/data/katepartui.rc are extracted into the catalog ktexteditor5
> 
> Without the definition of translationDomain in katepartui the queries for the translation of
> these strings in katepartui.rc are performed with the application translationDomain (e.g. "kate" 
> or "kwrite") and the strings are untranslated in the GUI.
> 
> With this patch and the patch from https://git.reviewboard.kde.org/r/121141/diff/ the queries 
> for translation of these strings in katepartui.rc are performed with the translationDomain "ktexteditor5"
> and e.g. the menu items in kate/kwrite are fully translated now.
> 
> 
> Diffs
> -----
> 
>   src/data/katepartui.rc 6673b64 
> 
> Diff: https://git.reviewboard.kde.org/r/121143/diff/
> 
> 
> Testing
> -------
> 
> Fully translated GUI in kate/kwrite
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141116/8ebd994f/attachment.html>