Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

[Arjun AK]

> On Nov. 14, 2014, 2:24 p.m., David Faure wrote:
> > if you want, but the sentence sounds like KRun only reads from that config file, while it also writes into it. This is why I consider it an implementation detail... the app doesnt need to care about it, right?

>the app doesnt need to care about it, right?

In this case it does, the app might need to have an option to re-enable the dialog(once "Do not ask again" has been set). If the name of the configuration file is not mentioned in the documentation, the developer will have to go through the source code to find it.


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120926/#review70361
-----------------------------------------------------------


On Nov. 1, 2014, 4:01 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120926/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 4:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Since `setShowScriptExecutionPrompt()` is used to specify whether a prompt should be shown or not, we don't neither need to check it again nor do we need to call `setRunExecutable()` inside KIO. The caller is anyway forced to do something like:
> 
>     if (value == "alwaysAsk") {
>         run->setShowScriptExecutionPrompt(true);
>     } else {
>         run->setRunExecutables(value == "execute");
>     }
> 
> 
> Diffs
> -----
> 
>   src/widgets/krun.h cd5bcaa 
> 
> Diff: https://git.reviewboard.kde.org/r/120926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141116/2bd894eb/attachment.html>