Review Request 121098: Restore filedialog functionality for modal dialogs.

[Jeremy Whiting]

> On Nov. 14, 2014, 4:16 p.m., Martin Klapetek wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303
> > <https://git.reviewboard.kde.org/r/121098/diff/1/?file=327582#file327582line301>
> >
> >     Looking at QDialog docs, it says
> >     
> >     "modal : bool
> >     This property holds whether show() should pop up the dialog as modal or modeless."
> >     
> >     So as the modal is being set here, shouldn't the "if (windowModality == Qt::NonModal) {" just be removed instead and always call show()?

Yep, I've tried just removing the if, that makes it appear when the static QFileDialog methods are called, but you can't interact with it. Clicking anywhere in the dialog itself does nothing. As reported here: https://bugs.kde.org/show_bug.cgi?id=334963


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121098/#review70384
-----------------------------------------------------------


On Nov. 10, 2014, 11:17 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121098/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 11:17 a.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Before David's astyle commit, the show method used to call m_dialog->exec
> if the window flags weren't nonmodal (i.e. modal dialogs). This got removed somehow.
> BUG:334963
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca192946f0da2b357b33e93a57ef0de05135b 
> 
> Diff: https://git.reviewboard.kde.org/r/121098/diff/
> 
> 
> Testing
> -------
> 
> fifteen puzzle config with patch from https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you choose a file.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141115/bf564992/attachment.html>