Review Request 121118: KEmoticons: Add a KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons

Daniel Vrátil dvratil at redhat.com
Fri Nov 14 12:36:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121118/
-----------------------------------------------------------

Review request for KDE Frameworks, Albert Astals Cid and David Faure.


Repository: kemoticons


Description
-------

This patch is related to /r/121094, which moves KTextToHTML conversion utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons needed for smileys conversion, I created a plugin in KEmoticons that implements the interface from KCoreAddons. This is based on the FrameworkIntegrationPlugin.


Diffs
-----

  CMakeLists.txt 1550bfe 
  autotests/CMakeLists.txt 29b7eb6 
  autotests/ktexttohtmlplugintest.cpp PRE-CREATION 
  src/CMakeLists.txt 7b10087 
  src/integrationplugin/CMakeLists.txt PRE-CREATION 
  src/integrationplugin/kemoticonsintegrationplugin.h PRE-CREATION 
  src/integrationplugin/kemoticonsintegrationplugin.cpp PRE-CREATION 
  src/integrationplugin/ktexttohtml.h PRE-CREATION 
  src/integrationplugin/ktexttohtml.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121118/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141114/2fafdbc6/attachment.html>


More information about the Kde-frameworks-devel mailing list