Review Request 121076: Do not require KF5::Su on Windows

Pedro Francisco pedrogfrancisco at gmail.com
Wed Nov 12 14:45:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/#review70280
-----------------------------------------------------------

Ship it!


Ship It!

- Pedro Francisco


On Nov. 8, 2014, 10:14 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121076/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 10:14 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> kdepasswd, which requires it, is already disabled on Windows. There is also konq-plugins/shellcmdplugins which was also disabled on Windows, but konq-plugins is entirely disabled now.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f02b069 
> 
> Diff: https://git.reviewboard.kde.org/r/121076/diff/
> 
> 
> Testing
> -------
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141112/d5846fea/attachment.html>


More information about the Kde-frameworks-devel mailing list