Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 1:12 p.m.)


Review request for KDE Frameworks.


Repository: frameworkintegration


Description
-------

This patch is related to /r/121094, which moves KTextToHTML conversion utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons needed for smileys conversion, I added the actual KEmoticons code here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency for KMessageBox.

This patch refactors the FrameworkIntegrationPlugin a bit - I split the KMessageBox-specific code into a separate file, and added a new file with the KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking more and more classes into a single file :-)


Diffs (updated)
-----

  CMakeLists.txt 3721bfa 
  src/integrationplugin/CMakeLists.txt 3395368 
  src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
  src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
  src/integrationplugin/kmessagebox.h PRE-CREATION 
  src/integrationplugin/kmessagebox.cpp PRE-CREATION 
  src/integrationplugin/ktexttohtml.h PRE-CREATION 
  src/integrationplugin/ktexttohtml.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121095/diff/


Testing
-------

Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems to work.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141111/ed66fa80/attachment.html>