Review Request 121100: Add qCDebug statements back into knewstuff sources.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121100/#review70228
-----------------------------------------------------------

Ship it!


Looks sane.

Some minor (and unrelated) comments inline.


src/attica/atticaprovider.cpp
<https://git.reviewboard.kde.org/r/121100/#comment49099>

    would probably make sense to not comment it here, or show a warning. (I don't know how critical this particular FIXME is.)



src/core/installation.cpp
<https://git.reviewboard.kde.org/r/121100/#comment49100>

    unrelated to this patch, but this looks quite fishy, yet easy to fix.



tests/knewstuff2_test.cpp
<https://git.reviewboard.kde.org/r/121100/#comment49101>

    WTF? (Unrelated, yes.)


- Sebastian Kügler


On Nov. 11, 2014, 2:42 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121100/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 2:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Add qCDebug statements back into knewstuff sources.
> 
> 
> Diffs
> -----
> 
>   tests/knewstuff2_standard.cpp e44628b549ea5ad3b002c3a11eac298b92b5a6ae 
>   tests/khotnewstuff.cpp 1aba7de48a8b7cf7f8886957fc473bf0cc631a13 
>   tests/knewstuff2_cache.cpp e7e8a48666237f468d986e99a8c472fe37fd7a77 
>   tests/knewstuff2_download.cpp 39d756e30f5b4f56f9254ae1e08c0d8310daf4d1 
>   src/staticxml/staticxmlprovider.cpp 434ecef0b71543bf4504c9781d1d3a21b9cf6e34 
>   src/ui/entrydetailsdialog.cpp 8a36d33f9a390a211313b11fba65030261a54446 
>   src/ui/itemsgridviewdelegate.cpp 19ddc59eb4acbb2b7a591119453be407d01d9a9f 
>   src/ui/itemsmodel.cpp 0254e88a5c16a2f8c5818a45bb7ec28eef4973e8 
>   src/ui/itemsviewbasedelegate.cpp 5137beb93ee8cccd15b28b9a9f47eff60fc17fc8 
>   src/ui/itemsviewdelegate.cpp 5e9b985cc155d141664a944b3d2bd1e751d96136 
>   src/uploaddialog.cpp 1a087b30a7fc6198062f0f7a012ae37ed6f396af 
>   src/core/engine.cpp 017154323cfd3f48fc61c0c705d4842f3c2f94a4 
>   src/core/entryinternal.cpp d3af619e9908b2f9e6176c7c87eda44897e93f0a 
>   src/core/installation.cpp d8de905bd2d19d098fb08a64897f5617f04e996d 
>   src/core/upload.cpp 166e69417b687fef6e89ef7fb5c383ec478c5c2d 
>   src/core/xmlloader.cpp 2cee02b66f8ec2a0f1fc407aaadd0ea397b89939 
>   src/downloadmanager.cpp 60d0d37ef0bd35efdcfe5e6ac58fefb3a2ce9954 
>   src/downloadwidget.cpp 358bb8b5222ac596dd3f0025778cd2721c1f3120 
>   src/entry.h df3095e3f75d2f6ca15daf9e87172990214d6352 
>   src/entry.cpp 48a92a7db04eec9b7b1b824841c95c280f31fab7 
>   autotests/knewstuffentrytest.cpp bf55f063dc8cb0b0984fdc73501a13107241a75a 
>   src/attica/atticaprovider.cpp 7103b59d62de468ba0c21a6b6260e5befc8575a2 
>   src/core/cache.cpp 3ba6cb4f4d344781d7b95c966d0a0643777e1e6a 
>   tests/knewstuff2_test.cpp ee2ead451be06854ea65ee9128231d37b118355c 
> 
> Diff: https://git.reviewboard.kde.org/r/121100/diff/
> 
> 
> Testing
> -------
> 
> Builds and works still, more debug output filterable with the kanagram logging category.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141111/db2eb555/attachment-0001.html>