Review Request 121099: Fix kautosave doesn't work with more than 1 file per application.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121099/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Repository: kcoreaddons


Description
-------

kautosave doesn't work when any app tries to use a second filename, because it doesn't filter on filename.  The unit tests can be droppped into master to show the problem, if you remove the include on line 21.

This patch:
1. Adds unit tests to test more behavior mentioned in the header.
2. Fixes kautosave working with multple files per application.
3. Fixes filenaming brittleness, which would cause kautosave to randomly fail when the last 3 randomly generated characters in the filename matched any 3 consequtive chracters in the managed filename.

Original patch by Andreas Xavier (https://git.reviewboard.kde.org/r/119530)

Items from original review have been fixed.


Diffs
-----

  src/lib/io/kautosavefile_p.cpp PRE-CREATION 
  autotests/kautosavefiletest.h cf70f4c6a4e1f093c431eff6ff25e6f510e84a53 
  autotests/kautosavefiletest.cpp ec0309e5fda95e01bbed31bd2fe91f9b7a48bec0 
  src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
  src/lib/io/kautosavefile.h 05cc3aedc248665c8727ade3b86b524275c013ca 
  src/lib/io/kautosavefile.cpp 13a13d7cfb26194be3edf7cbdcd1d39309b79465 
  src/lib/io/kautosavefile_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121099/diff/


Testing
-------

It builds and the test passes.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141111/c9e724f3/attachment.html>