Review Request 121093: Revert "don't recompile exported classes, link to their dll"

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121093/
-----------------------------------------------------------

(Updated Nov. 10, 2014, 2:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting.


Repository: knewstuff


Description
-------

The `*_p.h` files do not have any export macros. Instead we now
set -DKNEWSTUFF_STATIC_DEFINE which should prevent the export
macros from expanding to anything even on Windows.

This fixes the compile error for me:

This fixes the compile/link errors of the unit tests:

Linking CXX executable knewstuffentrytest
/home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference
to 'KNS3::EntryInternal::EntryInternal()'
/home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference
to 'KNS3::EntryInternal::setEntryXML(QDomElement const&)'
/home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference
to 'KNS3::EntryInternal::toEntry() const'
/home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference
to 'KNS3::EntryInternal::~EntryInternal()'
collect2: error: ld returned 1 exit status

and similar. The tests compile again and work properly.

This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731.


Diffs
-----

  autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b 

Diff: https://git.reviewboard.kde.org/r/121093/diff/


Testing
-------

Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ 


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141110/860ee16e/attachment-0001.html>