Review Request 121090: Move kio-mtp to kio-extras
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Nov 10 14:14:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121090/#review70188
-----------------------------------------------------------
+1 makes sense to me.
- Aleix Pol Gonzalez
On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121090/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 9:30 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style.
>
> Discussion about this move can be found here http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2
>
>
> Diffs
> -----
>
> mtp/kio_mtp_helpers.h PRE-CREATION
> mtp/kio_mtp_helpers.cpp PRE-CREATION
> mtp/mtp-network.desktop PRE-CREATION
> mtp/mtp.protocol PRE-CREATION
> mtp/solid_mtp.desktop PRE-CREATION
> mtp/filecache.cpp PRE-CREATION
> mtp/kio-mtp.kdev4 PRE-CREATION
> mtp/kio_mtp.h PRE-CREATION
> mtp/kio_mtp.cpp PRE-CREATION
> CMakeLists.txt 8f82688
> mtp/CMakeLists.txt PRE-CREATION
> mtp/COPYING PRE-CREATION
> mtp/LICENCE PRE-CREATION
> mtp/Messages.sh PRE-CREATION
> mtp/README PRE-CREATION
> mtp/devicecache.h PRE-CREATION
> mtp/devicecache.cpp PRE-CREATION
> mtp/filecache.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121090/diff/
>
>
> Testing
> -------
>
> I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine.
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141110/4c731a19/attachment.html>
More information about the Kde-frameworks-devel
mailing list