Review Request 121007: Fix warning when using newer upower backend.

Milian Wolff mail at milianw.de
Fri Nov 7 14:13:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121007/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 2:13 p.m.)


Review request for KDE Frameworks, Àlex Fiestas, David Faure, and Lukáš Tinkl.


Changes
-------

reverted the logic, I now check for the new signature and connect to it if possible, otherwise do the fallback. still no warning on my system (i.e. it connects to the correct signals).


Bugs: 339014
    https://bugs.kde.org/show_bug.cgi?id=339014


Repository: solid


Description
-------

"No such signal org::freedesktop::UPower::DeviceAdded(...)"

The signature change can be detected at runtime using Qt's QMetaObject
introspection mechanism. That prevents us from emitting the two
pesky warnings at runtime, polluting our konsoles.

Google is full of that warning, and there is also: https://bugzilla.redhat.com/show_bug.cgi?id=1056769


Diffs (updated)
-----

  CMakeLists.txt f7c500e 

Diff: https://git.reviewboard.kde.org/r/121007/diff/


Testing
-------

warning gone!


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141107/57f84ae7/attachment.html>


More information about the Kde-frameworks-devel mailing list