Review Request 121007: Fix warning when using newer upower backend.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121007/#review69983
-----------------------------------------------------------


Thank you very much for looking into this. I talked to Lukas Tinkl about it when we met, though, and IIRC he said that it couldn't be fixed that simply (because of the dbus signal magic)? I'm not sure though. Did you check that indexOfSignal("DeviceAdded(QDBusObjectPath)") works?
(simpler than downgrading UPower).

- David Faure


On Nov. 7, 2014, 10:23 a.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121007/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 10:23 a.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and David Faure.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> "No such signal org::freedesktop::UPower::DeviceAdded(...)"
> 
> The signature change can be detected at runtime using Qt's QMetaObject
> introspection mechanism. That prevents us from emitting the two
> pesky warnings at runtime, polluting our konsoles.
> 
> Google is full of that warning, and there is also: https://bugzilla.redhat.com/show_bug.cgi?id=1056769
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/backends/upower/upowermanager.cpp 53c858093a1c439f0faca0c956a51199f4e882e4 
> 
> Diff: https://git.reviewboard.kde.org/r/121007/diff/
> 
> 
> Testing
> -------
> 
> warning gone!
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141107/f29f3bf8/attachment.html>