Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

Martin Klapetek martin.klapetek at gmail.com
Mon Nov 3 21:21:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120959/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 10:21 p.m.)


Review request for KDE Frameworks, KDEPIM-Libraries and Laurent Montel.


Changes
-------

Add the frameworks review group


Repository: kdepimlibs


Description
-------

The generated headers have "#include "kpimutils/linklocator.h" but since they are being installed in KPIMUtils/KPIMUtils/, the inclusion fails because those real headers are installed in KPIMUtils/kpimutils (rather than KPIMUtils/KPIMUtils/kpimutils). I also don't see a reason why to install into KPIMUtils/KPIMUtils/...?


Diffs
-----

  kpimutils/src/CMakeLists.txt 1acc88e 

Diff: https://git.reviewboard.kde.org/r/120959/diff/


Testing
-------

Akonadi-facebook fails to build with "kpimutils/linklocator.h - No such file or directory", with this it no longer gives the error.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141103/81dd21b6/attachment.html>


More information about the Kde-frameworks-devel mailing list