Review Request 120947: Define <source_files_var> for ecm_create_qm_loader

Alex Merry alex.merry at kde.org
Sun Nov 2 20:11:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120947/#review69685
-----------------------------------------------------------

Ship it!


Yep... there's no point populating that variable and not using it.

- Alex Merry


On Nov. 2, 2014, 7:54 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120947/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 7:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> add definition for <source_files_var> for ecm_create_qm_loader to load the translation catalog
> 
> 
> Diffs
> -----
> 
>   src/gui/CMakeLists.txt ad29bf3 
> 
> Diff: https://git.reviewboard.kde.org/r/120947/diff/
> 
> 
> Testing
> -------
> 
> Catalog is loaded with patch
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141102/90ec7929/attachment.html>


More information about the Kde-frameworks-devel mailing list