Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

Matthew Dawson matthew at mjdsystems.ca
Sat May 31 03:42:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/
-----------------------------------------------------------

(Updated May 30, 2014, 11:42 p.m.)


Review request for KDE Frameworks, Plasma and Ivan Čukić.


Changes
-------

Change the macro_optional_add_subdirectory to a proper option.  This also disables the KCM when the daemon is disabled.


Repository: kactivities


Description
-------

To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled.

I'm not sure if this is the best way to do this.  If there is any better way, I'll update the patch as appropriate.


Diffs (updated)
-----

  src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 

Diff: https://git.reviewboard.kde.org/r/118340/diff/


Testing
-------

Visually inspected install directories.  Seems to remove only what is necessary.


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140531/80b3adc3/attachment.html>


More information about the Kde-frameworks-devel mailing list